Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 9999 data values with nan #143

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

callumrollo
Copy link
Collaborator

This PR will fix Issue #123 where 9999 error values from the legato are interpreted as valid pressures. All 9999 are replaced with nan during raw_to_timeseries.

Need to add tests.

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 77.49% // Head: 77.56% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (4a7c830) compared to base (a32a585).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 4a7c830 differs from pull request most recent head 3098843. Consider uploading reports for the commit 3098843 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   77.49%   77.56%   +0.07%     
==========================================
  Files           7        7              
  Lines        1271     1275       +4     
==========================================
+ Hits          985      989       +4     
  Misses        286      286              
Impacted Files Coverage Δ
pyglider/seaexplorer.py 79.22% <100.00%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@callumrollo callumrollo marked this pull request as ready for review January 17, 2023 08:34
@callumrollo callumrollo merged commit d3950ce into c-proof:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants