FIX: refactor dbdreader code to just do one pass #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hvdosser if you get a chance this week, can you run this version on a delayed-mode data set and make sure the results are comparable to the old processing? I think some of the interpolation will be different, but... |
|
@hvdosser did you try this branch yet? If it's OK, please merge. Thanks! |
|
Compared branch with main branch for delayed mode data for one mission. The L0 time series and grid files were very slightly smaller, and the processing ran more quickly. Data looked good, and metadata was unchanged. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbdreader will sync other variables with a main variable. Here make the main variable adjustable, and
sci_water_tempby default. Some troublesome files work better under this scheme than the old scheme of using time (the time stamp seemed corrupt in the bad files).The only issue here may be memory usage for large data sets? There may need to be a way to read files in batches at some point, but hopefully this works for now. If it doesn't another approach is to go back to the old way, and just sync this way.