Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on 32bit arch #250

Merged
merged 7 commits into from
Jul 6, 2022
Merged

Fix tests on 32bit arch #250

merged 7 commits into from
Jul 6, 2022

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jul 6, 2022

I've been preparing a 0.19 release - but the thorough opam CI pointed out a couple of issues,
including that the expect tests fail on 32-bit architectures.

This PR is thus a quick-and-dirty fix to solve that - thereby fixing #152.

  • On 32-bit the distribution of Random will be different. This is solved by including separate 32/64-bit expected outputs.
  • A few unit tests were comparing shrink counts - which also differ! Those tests are rewritten to no longer test the shrink count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant