Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all auth plugins #41

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Support all auth plugins #41

merged 1 commit into from
Feb 21, 2019

Conversation

c-bata
Copy link
Owner

@c-bata c-bata commented Jan 10, 2019

fix #40

@c-bata c-bata force-pushed the support-all-auth-plugins branch 2 times, most recently from b4be8a1 to cde6f47 Compare February 21, 2019 14:01
@c-bata c-bata force-pushed the support-all-auth-plugins branch from cde6f47 to fa7ef4f Compare February 21, 2019 14:05
@c-bata
Copy link
Owner Author

c-bata commented Feb 21, 2019

Remove azure auth plugin because of build failure.

$ make build
go build -ldflags "-X 'main.version=v1.0.5' -X 'main.revision=cde6f47'"
# github.com/c-bata/kube-prompt/vendor/k8s.io/client-go/plugin/pkg/client/auth/azure
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:246:4: cannot use expiresIn (type string) as type json.Number in field value
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:247:4: cannot use expiresOn (type string) as type json.Number in field value
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:248:4: cannot use expiresOn (type string) as type json.Number in field value
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:265:23: cannot use token.token.ExpiresIn (type json.Number) as type string in assignment
vendor/k8s.io/client-go/plugin/pkg/client/auth/azure/azure.go:266:23: cannot use token.token.ExpiresOn (type json.Number) as type string in assignment
make: *** [build] Error 2

@c-bata c-bata merged commit c504fdd into master Feb 21, 2019
@c-bata c-bata deleted the support-all-auth-plugins branch February 21, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing client-go oidc auth helper (and others)
1 participant
@c-bata