Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing client-go oidc auth helper (and others) #40

Closed
dnwe opened this issue Jan 8, 2019 · 2 comments · Fixed by #41
Closed

Missing client-go oidc auth helper (and others) #40

dnwe opened this issue Jan 8, 2019 · 2 comments · Fixed by #41

Comments

@dnwe
Copy link

dnwe commented Jan 8, 2019

Currently kube-prompt only imports the gcp auth helper

import (
"k8s.io/client-go/kubernetes"
_ "k8s.io/client-go/plugin/pkg/client/auth/gcp" // register gcp auth helper
"k8s.io/client-go/tools/clientcmd"
)

Please could you also import the oidc helper with a blank identifier so it is included in the release builds?

 _ "k8s.io/client-go/plugin/pkg/client/auth/oidc"

Although I wonder if you might want to just import support for all of the available auth plugins rather than adding them one-by-one when people request them?

@c-bata
Copy link
Owner

c-bata commented Jan 10, 2019

Thanks. I didn't notice this problem because I only use Kubernetes on GKE(gcp).
OK! I add all blank imports for available auth plugins.

@c-bata
Copy link
Owner

c-bata commented Feb 21, 2019

Hi @dnwe . Please update your kube-prompt.
https://github.com/c-bata/kube-prompt/releases/tag/v1.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants