Merge pull request #39 from byu-oit/reduce-noise

Change default tags from `{}` to `null`
byu-oit · Oct 26, 2022 · 673fc29 · 673fc29
2 parents 9d8e64f + a249686
commit 673fc29
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -13,7 +13,7 @@ customized solution you may need to use this code more as a pattern or guideline
 
 ```hcl
 module "my_app" {
-  source                       = "github.com/byu-oit/terraform-aws-fargate-api?ref=v5.0.0"
+  source                       = "github.com/byu-oit/terraform-aws-fargate-api?ref=v5.0.1"
   app_name                     = "example-api"
   container_port               = 8000
   primary_container_definition = {
@@ -121,7 +121,7 @@ module "my_app" {
 | scaling_down_metric_alarm_config  | [object](#scaling_down_metric_alarm_config) | Optional advanced configuration for scaling the down metric alarm if 'autoscaling_config' is in use."                                                                                                                                                                                                                                                                                                | See object definition [object](#scaling_down_metric_alarm_config)                      |
 | log_group_name                    | string                                      | CloudWatch log group name.                                                                                                                                                                                                                                                                                                                                                                           |                                                                                        |
 | log_retention_in_days             | number                                      | CloudWatch log group retention in days                                                                                                                                                                                                                                                                                                                                                               | 120                                                                                    |
-| tags                              | map(string)                                 | A map of AWS Tags to attach to each resource created                                                                                                                                                                                                                                                                                                                                                 | {}                                                                                     |
+| tags                              | map(string)                                 | A map of AWS Tags to attach to each resource created                                                                                                                                                                                                                                                                                                                                                 | `null`                                                                                 |
 | lb_logging_enabled                | bool                                        | Option to enable logging of load balancer requests.                                                                                                                                                                                                                                                                                                                                                  | false                                                                                  |
 | lb_logging_bucket_name            | string                                      | Required if `lb_logging_enabled` is true. A bucket to store the logs in with an a [load balancer access policy](https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-access-logs.html#attach-bucket-policy) attached.                                                                                                                                                              |                                                                                        |
 | fargate_platform_version          | string                                      | Version of the Fargate platform to run.                                                                                                                                                                                                                                                                                                                                                              | 1.4.0                                                                                  |

diff --git a/examples/logging/logging.tf b/examples/logging/logging.tf
@@ -24,7 +24,7 @@ data "aws_elb_service_account" "main" {}
 //  name = "fake-example-cluster"
 //}
 module "fargate_api" {
-  source = "github.com/byu-oit/terraform-aws-fargate-api?ref=v5.0.0"
+  source = "github.com/byu-oit/terraform-aws-fargate-api?ref=v5.0.1"
   //  source           = "../../" // for local testing
   app_name = "example-api"
   //  ecs_cluster_name = aws_ecs_cluster.existing.name

diff --git a/examples/simple/simple.tf b/examples/simple/simple.tf
@@ -21,7 +21,7 @@ module "acs" {
 //  name = "fake-example-cluster"
 //}
 module "fargate_api" {
-  source = "github.com/byu-oit/terraform-aws-fargate-api?ref=v5.0.0"
+  source = "github.com/byu-oit/terraform-aws-fargate-api?ref=v5.0.1"
   // source   = "../../" // for local testing
   app_name = "example-api"
   //  ecs_cluster_name = aws_ecs_cluster.existing.name

diff --git a/variables.tf b/variables.tf
@@ -303,7 +303,7 @@ variable "log_retention_in_days" {
 variable "tags" {
   type        = map(string)
   description = "A map of AWS Tags to attach to each resource created"
-  default     = {}
+  default     = null
 }
 variable "lb_logging_enabled" {
   type        = bool