Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TF module versions #695

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Bump TF module versions #695

merged 1 commit into from
Oct 26, 2022

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Oct 26, 2022

I'm just eager to see what happens to the Terraform plans as a result of these changes.

terraform-aws-fargate-api?ref=v5.0.1 release notes
terraform-aws-postman-test-lambda?ref=v4.0.1 release notes

@github-actions
Copy link

github-actions bot commented Oct 26, 2022

Terraform Plan:

will create 1 resource:

  • local_file - appspec_json

will update 2 resources:

  • aws_alb_listener - https
  • aws_alb_listener - test_listener

will replace (delete then create) 1 resource:

  • aws_ecs_task_definition - task_def

see details

@GaryGSC
Copy link
Member Author

GaryGSC commented Oct 26, 2022

I feel safe merging this without further review since this would've been two auto-merged Dependabot PRs anyways.

This brings us down to 4 usages of deprecated S3 resources:

│ Warning: Argument is deprecated
│ 
│   with module.app.module.postman_test_lambda.aws_s3_bucket_object.collections[0],
│   on .terraform/modules/app.postman_test_lambda/main.tf line 173, in resource "aws_s3_bucket_object" "collections":173:   bucket = aws_s3_bucket.postman_bucket[0].bucket
│ 
│ Use the aws_s3_object resource instead
│ 
│ (and 3 more similar warnings elsewhere)

@GaryGSC GaryGSC merged commit b04b86e into dev Oct 26, 2022
@GaryGSC GaryGSC deleted the bump-tf-modules branch October 26, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant