Use tfedit to stop directly using deprecated S3 resources

[GaryGSC]

We still use deprecated resources indirectly in our modules, but this takes us from 26 deprecated usages down to 14, overall.

Refs: #678

[github-actions]

Terraform Plan:

will create 8 resources:

• aws_s3_bucket_acl - my_s3_bucket_logs
• aws_s3_bucket_lifecycle_configuration - my_s3_bucket
• aws_s3_bucket_lifecycle_configuration - my_s3_bucket_logs
• aws_s3_bucket_logging - my_s3_bucket
• aws_s3_bucket_server_side_encryption_configuration - my_s3_bucket
• aws_s3_bucket_server_side_encryption_configuration - my_s3_bucket_logs
• aws_s3_bucket_versioning - my_s3_bucket
• local_file - appspec_json

will update 2 resources:

• aws_alb_listener - https
• aws_alb_listener - test_listener

will replace (delete then create) 1 resource:

• aws_ecs_task_definition - task_def

see details

[stuft2]

LGTM

[GaryGSC]

BTW, tfedit's README suggests migrating state (by using terraform import or a tool called tfmigrate) to keep Terraform from thinking it needs to create new resources for S3. For a deployed application, we might want to look into that. For this template, I didn't bother.

[GaryGSC]

I see now that the S3 Terraform documentation says:

Each of the new aws_s3_bucket_* resources relies on S3 API calls that utilize a PUT action in order to modify the target S3 bucket. These calls follow standard HTTP methods for REST APIs, and therefore should handle situations where the target configuration already exists. While it is not strictly necessary to import new aws_s3_bucket_* resources where the updated configuration matches the configuration used in previous versions of the AWS provider, skipping this step will lead to a diff in the first plan after a configuration change indicating that any new aws_s3_bucket_* resources will be created, making it more difficult to determine whether the appropriate actions will be taken.

These new resources should be identical to the existing configuration, so we can skip terraform import but we'll have to deal with a larger plan when we initially make the change.