Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run using Node.js 16, bump NPM & GHA deps #26

Merged
merged 10 commits into from
Nov 2, 2022
Merged

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Nov 2, 2022

This is considered breaking because of the change to using: 'node16' (since that requires a newer runner version). We're basically all using ubuntu-latest over at BYU, but we have some external users. Assuming this gets approval, I say we plan on releasing it as v2.0.0.

I was able to update most of the dependencies. This is what's left when I run yarn outdated:

Package                   Current Wanted  Latest  Package Type    URL
@types/node               16.18.3 16.18.3 18.11.9 devDependencies https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node
@typescript-eslint/parser 2.34.0  2.34.0  5.42.0  devDependencies https://github.com/typescript-eslint/typescript-eslint#readme
eslint                    5.16.0  5.16.0  8.26.0  devDependencies https://eslint.org
eslint-plugin-github      2.0.0   2.0.0   4.4.0   devDependencies https://github.com/github/eslint-plugin-github#readme
eslint-plugin-jest        22.21.0 22.21.0 27.1.3  devDependencies https://github.com/jest-community/eslint-plugin-jest#readme
eslint-plugin-prettier    3.4.1   3.4.1   4.2.1   devDependencies https://github.com/prettier/eslint-plugin-prettier#readme
Done in 0.78s.

The ESLint stuff is a mess of peer dependencies and rule changes that don't play nicely with our current .eslintrc.json.

@GaryGSC GaryGSC requested review from stuft2 and a team November 2, 2022 21:28
@GaryGSC
Copy link
Member Author

GaryGSC commented Nov 2, 2022

The main goals of this PR are to remove deprecation warnings and to resolve about a year and a half of technical debt.

@GaryGSC GaryGSC merged commit 1cd00ec into master Nov 2, 2022
@GaryGSC GaryGSC deleted the node16-and-deps branch November 2, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants