Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bench): display bench stats as comment in PR #995

Merged
merged 13 commits into from
Apr 19, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Apr 18, 2022

Fixes #992

Signed-off-by: Xavier Coulon [email protected]

@xcoulon xcoulon force-pushed the Issue992_benchstat_comments branch 2 times, most recently from cbe2efd to 5f6e275 Compare April 18, 2022 15:24
@xcoulon xcoulon force-pushed the Issue992_benchstat_comments branch from 5f6e275 to e4fee51 Compare April 18, 2022 15:37
Signed-off-by: Xavier Coulon <[email protected]>
@github-actions
Copy link

github-actions bot commented Apr 18, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              22.4ms ± 4%    22.9ms ± 2%  +2.32%  (p=0.043 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    64.6ms ± 3%    66.6ms ± 3%  +3.03%  (p=0.003 n=10+8)
RealDocumentProcessing/mocking.adoc-2           62.6ms ± 4%    63.6ms ± 8%    ~     (p=0.278 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              8.85MB ± 0%    8.85MB ± 0%    ~     (p=0.315 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    24.0MB ± 0%    24.0MB ± 0%    ~     (p=0.105 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.6MB ± 0%    21.6MB ± 0%    ~     (p=0.165 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                106k ± 0%      106k ± 0%    ~     (p=0.720 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      305k ± 0%      305k ± 0%    ~     (p=0.865 n=10+10)
RealDocumentProcessing/mocking.adoc-2             326k ± 0%      326k ± 0%  -0.00%  (p=0.005 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              22.4ms ± 4%    22.3ms ± 4%    ~     (p=0.971 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    64.6ms ± 3%    62.8ms ± 3%  -2.76%  (p=0.007 n=10+10)
RealDocumentProcessing/mocking.adoc-2           62.6ms ± 4%    63.8ms ± 4%    ~     (p=0.211 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              8.85MB ± 0%    8.85MB ± 0%    ~     (p=0.436 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    24.0MB ± 0%    24.0MB ± 0%    ~     (p=0.315 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.6MB ± 0%    21.6MB ± 0%  -0.00%  (p=0.017 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                106k ± 0%      106k ± 0%    ~     (p=0.370 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      305k ± 0%      305k ± 0%    ~     (p=0.432 n=10+10)
RealDocumentProcessing/mocking.adoc-2             326k ± 0%      326k ± 0%    ~     (p=0.084 n=10+10)

xcoulon added 4 commits April 18, 2022 21:42
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the Issue992_benchstat_comments branch from 85aa8fc to bac9485 Compare April 18, 2022 20:19
xcoulon added 3 commits April 18, 2022 22:20
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon force-pushed the Issue992_benchstat_comments branch from 5c78697 to f7fb611 Compare April 19, 2022 20:31
xcoulon added 4 commits April 19, 2022 22:41
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon merged commit 8d0abec into master Apr 19, 2022
@xcoulon xcoulon deleted the Issue992_benchstat_comments branch April 19, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show benchstat results as a comment in PRs
1 participant