refactor(parser): parse quotation marks instead of quoted strings #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 79.75% 79.86% +0.11%
==========================================
Files 86 86
Lines 6841 6800 -41
==========================================
- Hits 5456 5431 -25
+ Misses 877 869 -8
+ Partials 508 500 -8 |
drop the `types.QuotedString` type and simply focus on quotation marks (and their escaped variants), which is simpler but slightly more permissive with regards to surrounding spaces. Fixes bytesparadise#972 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue972_escape_curved_quotes
branch
from
eed6b9b to
07fbbfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop the
types.QuotedStringtype and simply focus on quotationmarks (and their escaped variants), which is simpler but slightly
more permissive with regards to surrounding spaces.
Fixes #972
Signed-off-by: Xavier Coulon [email protected]