fix(renderer): render predefined attributes as HTML entities #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes `{nbps}`, etc.
also, simplify rendering (no template needed)
Fixes bytesparadise#953
Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue953_render_nbsp
branch
from
57e5e63 to
6a520e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #954 +/- ##
==========================================
+ Coverage 79.59% 79.73% +0.14%
==========================================
Files 88 87 -1
Lines 6781 6760 -21
==========================================
- Hits 5397 5390 -7
+ Misses 883 870 -13
+ Partials 501 500 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes
{nbps}, etc.also, simplify rendering (no template needed)
Fixes #953
Signed-off-by: Xavier Coulon [email protected]