Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renderer): support 'data-uri' in images #877

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Nov 28, 2021

include the content of the image file (encoded in base64)
in the output, unless the file is not found or is not readable.

Fixes #853

Signed-off-by: Xavier Coulon [email protected]

include the content of the image file (encoded in base64)
in the output, unless the file is not found or is not readable.

Fixes bytesparadise#853

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #877 (de63ec7) into master (0b72891) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   80.27%   80.31%   +0.03%     
==========================================
  Files          85       85              
  Lines        6597     6610      +13     
==========================================
+ Hits         5296     5309      +13     
  Misses        813      813              
  Partials      488      488              

@xcoulon xcoulon merged commit a68a438 into bytesparadise:master Nov 28, 2021
@xcoulon xcoulon deleted the Issue853_data_uri_attribute branch November 28, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is embedding images supported? (data-uri attribute)
1 participant