-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation instructions #847
Conversation
Add `make install`
README.adoc
Outdated
@@ -57,6 +57,8 @@ This is a standard Go package, and it installs like you might expect. | |||
To install it in your `$GOPATH` (assuming `$GOPATH/bin` is on your path), just use `go install`: | |||
|
|||
$ go get -u github.com/bytesparadise/libasciidoc | |||
$ cd $GOPATH/src/github.com/bytesparadise/libasciidoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could replace the go get
command with something like git checkout github.com/bytesparadise/libasciidoc
. The go get
is more for users who want to add the library to their project, whereas the make install
is to have libasciidoc
available as a command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a new commit that updates this - let me know if that's what you meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this PR @dflock! I left a comment to suggest a small change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR update and my apologies for the late review @dflock.
I've left some further comments.
$ git checkout github.com/bytesparadise/libasciidoc | ||
$ cd libasciidoc | ||
$ make install | ||
$ sudo ln -s ./bin/libasciidoc /usr/bin/libasciidoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the make install
goal already copies the binary into $GOPATH/bin
so I think that we should ask the users to ensure that $GOPATH/bin
in $PATH
, instead of making a symlink into a directory of $PATH
. Also, sudo ln -s ./bin/libasciidoc /usr/bin/libasciidoc
won't work for Windows users :(
$ make install | ||
$ sudo ln -s ./bin/libasciidoc /usr/bin/libasciidoc | ||
|
||
Libasciidoc is a standard Go package, so if you want to use it as a library in your Go project & install it in your `$GOPATH` (assuming `$GOPATH/bin` is on your path), just use `go install`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that paragraph, I would simply refer to the case where the user wants to embed the library in her own project. Ib which case, it's go get
, not go install
|
||
To install it in your `$GOPATH` (assuming `$GOPATH/bin` is on your path), just use `go install`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just installed by running: $ go install github.com/bytesparadise/libasciidoc/cmd/libasciidoc@latest
replaced by #966 |
Add
make install