Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #847

Closed
wants to merge 2 commits into from
Closed

Update installation instructions #847

wants to merge 2 commits into from

Conversation

dflock
Copy link
Contributor

@dflock dflock commented Apr 9, 2021

Add make install

README.adoc Outdated
@@ -57,6 +57,8 @@ This is a standard Go package, and it installs like you might expect.
To install it in your `$GOPATH` (assuming `$GOPATH/bin` is on your path), just use `go install`:

$ go get -u github.com/bytesparadise/libasciidoc
$ cd $GOPATH/src/github.com/bytesparadise/libasciidoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could replace the go get command with something like git checkout github.com/bytesparadise/libasciidoc. The go get is more for users who want to add the library to their project, whereas the make install is to have libasciidoc available as a command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a new commit that updates this - let me know if that's what you meant?

Copy link
Member

@xcoulon xcoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR @dflock! I left a comment to suggest a small change

Copy link
Member

@xcoulon xcoulon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR update and my apologies for the late review @dflock.
I've left some further comments.

$ git checkout github.com/bytesparadise/libasciidoc
$ cd libasciidoc
$ make install
$ sudo ln -s ./bin/libasciidoc /usr/bin/libasciidoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the make install goal already copies the binary into $GOPATH/bin so I think that we should ask the users to ensure that $GOPATH/bin in $PATH, instead of making a symlink into a directory of $PATH. Also, sudo ln -s ./bin/libasciidoc /usr/bin/libasciidoc won't work for Windows users :(

$ make install
$ sudo ln -s ./bin/libasciidoc /usr/bin/libasciidoc

Libasciidoc is a standard Go package, so if you want to use it as a library in your Go project & install it in your `$GOPATH` (assuming `$GOPATH/bin` is on your path), just use `go install`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that paragraph, I would simply refer to the case where the user wants to embed the library in her own project. Ib which case, it's go get, not go install


To install it in your `$GOPATH` (assuming `$GOPATH/bin` is on your path), just use `go install`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just installed by running: $ go install github.com/bytesparadise/libasciidoc/cmd/libasciidoc@latest

@xcoulon
Copy link
Member

xcoulon commented Mar 4, 2022

replaced by #966

@xcoulon xcoulon closed this Mar 4, 2022
@xcoulon
Copy link
Member

xcoulon commented Mar 4, 2022

my apologies for not taking time to address this PR earlier @dflock :/
I've added a few changes in #966 and it's merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants