feat(parser): support custom substitutions on delimited blocks #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding missing tests for custom subs on verse blocks at the parser level, and for all subs at the rendering level also, fix missing "InlineMacros" rule in the "VerseMacro" subs. also, reorgnize tests so they all have the same structure, in the parser and renderer pkgs. Signed-off-by: Xavier Coulon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 81.25% 81.85% +0.59%
==========================================
Files 76 76
Lines 5014 4992 -22
==========================================
+ Hits 4074 4086 +12
+ Misses 606 572 -34
Partials 334 334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding missing tests for custom subs on verse blocks at the
parser level, and for all subs at the rendering level
also, fix missing "InlineMacros" rule in the "VerseMacro" subs.
also, reorgnize tests so they all have the same structure,
in the parser and renderer pkgs.
Signed-off-by: Xavier Coulon [email protected]