feature(renderer): version-label not honored #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 84.81% 84.80% -0.01%
==========================================
Files 75 75
Lines 5089 5087 -2
==========================================
- Hits 4316 4314 -2
Misses 488 488
Partials 285 285 |
This supports the version-label be changed, or even reset for document attributes. To support resetting this label, the initial value is located in the Predefined attributes, and a reset of the attribute is stored as a nil attribute value instead of deleting it from the attributes. This allows us to distinguish a reset as an override. This approach will be used for other predefined text values in follow ups. Fixes bytesparadise#710
xcoulon
reviewed
Jul 11, 2020
| if value, ok := value.(string); ok { | ||
| return value, true | ||
| } else if v, ok := a[key]; ok { | ||
| return fmt.Sprintf("%v", v), true | ||
| } | ||
| } | ||
| // check in predefined attributes |
There was a problem hiding this comment.
I guess that storing a nil value instead of removing it is because you also changed the priority for looking up attributes? We don't want to look in the predefined attributes if there was an explicit reset beforehand?
There was a problem hiding this comment.
Yes. I need a way to distinguish something that was reset vs something that was simply not assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports the version-label be changed, or even reset
for document attributes.
To support resetting this label, the initial value is located
in the Predefined attributes, and a reset of the attribute is
stored as a nil attribute value instead of deleting it from the
attributes. This allows us to distinguish a reset as an override.
This approach will be used for other predefined text values in
follow ups.
Fixes #710