bug(renderer): Wrong code for (TM) #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the code 153, which is not the same value used by asciidoctor, and doesn't uniformly render as the trademark symbol. Fixes bytesparadise#641
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
=======================================
Coverage 86.08% 86.08%
=======================================
Files 70 70
Lines 4672 4672
=======================================
Hits 4022 4022
Misses 400 400
Partials 250 250 |
|
good catch! thanks for this contribution @gdamore 🙌 |
|
Well, it was my fault in the first place. Lol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the code 153, which is not the same value used by
asciidoctor, and doesn't uniformly render as the trademark
symbol.
Fixes #641
(This PR should be mergeable/rebaseable as is, because it's changes are fairly isolated from other PRs currently outstanding.)