Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): allow fast-finish on Travsi-ci #43

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Nov 14, 2017

Signed-off-by: Xavier Coulon [email protected]

@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files          21       21           
  Lines        1601     1601           
=======================================
  Hits         1176     1176           
  Misses        332      332           
  Partials       93       93

@xcoulon xcoulon merged commit ca90f7b into bytesparadise:master Nov 15, 2017
xcoulon added a commit that referenced this pull request Nov 15, 2017
xcoulon added a commit to xcoulon/libasciidoc that referenced this pull request Feb 19, 2019
render all elements and apply substitutions, then if applicable
(ie, there were some substitutions), then parse the inline elements
again and render the elements, but with plain string output for
the StringElements to avoid double HTML escaping

also:
- do not treat `++` as an empty single plus passthrough (but
keep `++++++` as an empty triple plus passthrough for now)
- render `++` as `&bytesparadise#43;&bytesparadise#43;`
- accept that `InlineElementsWithoutSubtitution` can be empty
(which happens if the only content was `{blank}` which is trimmed
after rendering)

fixes bytesparadise#295

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this pull request Feb 19, 2019
render all elements and apply substitutions, then if applicable
(ie, there were some substitutions), then parse the inline elements
again and render the elements, but with plain string output for
the StringElements to avoid double HTML escaping

also:
- do not treat `++` as an empty single plus passthrough (but
keep `++++++` as an empty triple plus passthrough for now)
- render `++` as `&bytesparadise#43;&bytesparadise#43;`
- accept that `InlineElementsWithoutSubtitution` can be empty
(which happens if the only content was `{blank}` which is trimmed
after rendering)

fixes bytesparadise#295

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this pull request Feb 20, 2019
render all elements and apply substitutions, then if applicable
(ie, there were some substitutions), then parse the inline elements
again and render the elements, but with plain string output for
the StringElements to avoid double HTML escaping

also:
- do not treat `++` as an empty single plus passthrough (but
keep `++++++` as an empty triple plus passthrough for now)
- render `++` as `&#43;&#43;`
- accept that `InlineElementsWithoutSubtitution` can be empty
(which happens if the only content was `{blank}` which is trimmed
after rendering)

fixes #295

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon deleted the travis_fast_finish branch February 25, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant