Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser/renderer): support quoted text in links #360

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 22, 2019

Also, significant refactoring on the parsing of quoted text
Also, when a link has no text attribute, then omit in the
output AST.

Fixes #356

Signed-off-by: Xavier Coulon [email protected]

xcoulon added 2 commits May 22, 2019 23:38
Also, significant refactoring on the parsing of quoted text
Also, when a link has no `text` attribute, then omit in the
output AST.

Fixes bytesparadise#356

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #360 into master will decrease coverage by 1.93%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   88.08%   86.14%   -1.94%     
==========================================
  Files          46       47       +1     
  Lines        3641     4236     +595     
==========================================
+ Hits         3207     3649     +442     
- Misses        290      439     +149     
- Partials      144      148       +4

@xcoulon xcoulon merged commit e0ac68b into bytesparadise:master May 23, 2019
@xcoulon xcoulon deleted the Issue356_link_text_with_quoted_content branch May 23, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text formatting on link text does not work
1 participant