feat(parser/renderer): support block and paragraph quotes #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci
reviewed
Jul 31, 2018
| @@ -94,7 +99,7 @@ func renderTableOfContentSections(ctx *renderer.Context, elements []interface{}, | |||
| return nil, nil | |||
| } | |||
| resultBuf := bytes.NewBuffer(nil) | |||
| tableOfContentSectionSetTmpl.Execute(resultBuf, TableOfContentSectionGroup{ | |||
| tableOfContentSectionSetTmpl.Execute(resultBuf, TableOfContentsSectionGroup{ | |||
There was a problem hiding this comment.
Error return value of tableOfContentSectionSetTmpl.Execute is not checked
also: - fix missing ID and title in admonition blocks (delimited blocks) - fix grammar for listing blocks and verse blocks - fix parsing/rendering of trailing spaces: included in the AST after parsing, but removed during rendering on the last element of a line. fixes bytesparadise#141 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue141_support_quotes
branch
from
0119765 to
57926ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 83.21% 83.73% +0.51%
==========================================
Files 34 34
Lines 2342 2385 +43
==========================================
+ Hits 1949 1997 +48
+ Misses 255 252 -3
+ Partials 138 136 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also:
the AST after parsing, but removed during rendering on the
last element of a line.
fixes #141
Signed-off-by: Xavier Coulon [email protected]