Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate alt text from filename for data-uri images #1115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: generate alt text from filename for data-uri images #1115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pkg/renderer/sgml/html5/image_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,5 +427,21 @@ image::favicon-glasses-16x16.png[Glasses]`
Expect(RenderHTML(source)).To(MatchHTML(expected))
// TODO: check that the log/output contains a WARNING message (`image to embed not found or not readable`)
})

It("missing alt text", func() {
source := `
:imagesdir: ../../../../test/images
:data-uri:

image::favicon-glasses-16x16.png[]`

expected := `<div class="imageblock">
<div class="content">
<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAABSklEQVQ4je2Rz0oCURSHT7ipd5ByExGmc28zc++M946OIrhxGgxHqE2N7XJVy8I3cCO4dB2hLnwC+4MY+A6CLgUV3BrObVFOYZugrR+c1fdbnPM7ABt+sgUAgT/kAl/ZTxBhL5jwuZw6WWq261G7uJCT1hhR3pUIr0uE1xHlXTlpjaldXGi268kpa4kJnyPCn0FS2SM7vxX55lQ4rZlwWjORb0yEcXEnEOVDRPnQuLwX+cbk2zengp3dCET4Axwd06jhln25GrNUERLhOUllp2ap8ssbbllEZD0CwaC+o9lX7+sB3bn2wrK8e4hjezGn5K17zS4uQqHQNgAAYJp4tWp9f71stSewZr6tesK62c9We/6ZVq0vkJZ48ouUFB0jGu+omcJISecGiLA2QnR/5aMKO0CEtZV0bqBmCiNE452wGkP/f/wGAAD4AGCWrt/5+Pc0AAAAAElFTkSuQmCC" alt="favicon glasses 16x16">
</div>
</div>
`
Expect(RenderHTML(source)).To(MatchHTML(expected))
})
})
})
2 changes: 1 addition & 1 deletion pkg/renderer/sgml/image.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (r *sgmlRenderer) renderImageBlock(ctx *context, img *types.ImageBlock) (st
return "", errors.Wrap(err, "unable to render image")
}
src := r.getImageSrc(ctx, img.Location)
alt, err := r.renderImageAlt(img.Attributes, src)
alt, err := r.renderImageAlt(img.Attributes, img.Location.ToString())
if err != nil {
return "", errors.Wrap(err, "unable to render image")
}
Expand Down