Add basename function to sgml FuncMap #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1104 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 89 89
Lines 8940 8941 +1
=======================================
+ Hits 6937 6938 +1
Misses 1509 1509
Partials 494 494 |
xcoulon
approved these changes
Feb 28, 2023
|
@davidgamba-au could you solve the conflicts on the PR, please? |
DavidGamba
force-pushed
the
add-filepath-base
branch
from
33e585d to
3deb666
Compare
|
@xcoulon merge conflicts fixed! Thanks for the quick review! |
This function is necessary to allow custom backends to only use the
basename of an image in cases where images are stored as attachments.
blockImageTmpl = `<image ><attachment filename="{{ basename .Src }}" /></image>`
DavidGamba
force-pushed
the
add-filepath-base
branch
from
3deb666 to
3d22367
Compare
|
@xcoulon rebased the latest master again. PTAL when you have a chance. Thanks! |
xcoulon
approved these changes
Mar 9, 2023
|
thanks @DavidGamba! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is necessary to allow custom backends to only use the basename of an image in cases where images are stored as attachments.