Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): remove unnecessary 'RawApostrophe' grammar rule #1072

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jul 25, 2022

Signed-off-by: Xavier Coulon [email protected]

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              38.2ms ± 1%    38.2ms ± 1%   ~     (p=0.541 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    95.4ms ± 1%    95.3ms ± 1%   ~     (p=0.436 n=10+10)
RealDocumentProcessing/mocking.adoc-2            104ms ± 1%     104ms ± 1%   ~     (p=0.063 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              12.8MB ± 0%    12.8MB ± 0%   ~     (p=0.546 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    30.9MB ± 0%    30.9MB ± 0%   ~     (p=1.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           28.7MB ± 0%    28.7MB ± 0%   ~     (p=0.968 n=9+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                175k ± 0%      175k ± 0%   ~     (p=0.328 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2      456k ± 0%      456k ± 0%   ~     (p=0.810 n=10+10)
RealDocumentProcessing/mocking.adoc-2             486k ± 0%      486k ± 0%   ~     (p=0.889 n=9+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              16.8ms ± 1%    38.2ms ± 1%  +127.79%  (p=0.000 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    47.9ms ± 1%    95.3ms ± 1%   +98.79%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           47.5ms ± 1%   103.8ms ± 1%  +118.42%  (p=0.000 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              8.85MB ± 0%   12.83MB ± 0%   +45.03%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    24.0MB ± 0%    30.9MB ± 0%   +28.75%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           21.6MB ± 0%    28.7MB ± 0%   +32.71%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                106k ± 0%      175k ± 0%   +64.89%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2      305k ± 0%      456k ± 0%   +49.61%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             326k ± 0%      486k ± 0%   +48.86%  (p=0.000 n=7+10)

@xcoulon xcoulon merged commit 5e5a4c6 into bytesparadise:master Jul 25, 2022
@xcoulon xcoulon deleted the remove_rawapostrophe_rule branch July 25, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant