Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): fix benchstat reports #1059

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 25, 2022

compare old vs new, not the opposite :/

Signed-off-by: Xavier Coulon [email protected]

compare old vs new, not the opposite :/

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #1059 (dc7b008) into master (a2de2b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1059   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files          85       85           
  Lines        7167     7167           
=======================================
  Hits         5778     5778           
  Misses        871      871           
  Partials      518      518           

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.8ms ± 1%    25.7ms ± 1%    ~     (p=0.279 n=8+8)
RealDocumentProcessing/vertx-examples.adoc-2    66.4ms ± 1%    66.3ms ± 0%    ~     (p=0.356 n=10+9)
RealDocumentProcessing/mocking.adoc-2           71.9ms ± 0%    72.1ms ± 1%    ~     (p=0.315 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.8MB ± 0%    10.8MB ± 0%    ~     (p=0.743 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2    27.2MB ± 0%    27.2MB ± 0%  +0.02%  (p=0.023 n=10+10)
RealDocumentProcessing/mocking.adoc-2           25.0MB ± 0%    25.0MB ± 0%    ~     (p=0.796 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                126k ± 0%      126k ± 0%    ~     (p=0.795 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2      341k ± 0%      341k ± 0%  +0.01%  (p=0.020 n=10+10)
RealDocumentProcessing/mocking.adoc-2             374k ± 0%      374k ± 0%    ~     (p=0.671 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.8ms ± 1%    16.7ms ± 0%  -35.29%  (p=0.000 n=8+8)
RealDocumentProcessing/vertx-examples.adoc-2    66.4ms ± 1%    47.9ms ± 1%  -27.81%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           71.9ms ± 0%    47.6ms ± 0%  -33.86%  (p=0.000 n=10+8)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.8MB ± 0%     8.8MB ± 0%  -18.09%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.2MB ± 0%    24.0MB ± 0%  -11.73%  (p=0.000 n=10+8)
RealDocumentProcessing/mocking.adoc-2           25.0MB ± 0%    21.6MB ± 0%  -13.54%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                126k ± 0%      106k ± 0%  -15.82%  (p=0.000 n=9+8)
RealDocumentProcessing/vertx-examples.adoc-2      341k ± 0%      305k ± 0%  -10.49%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             374k ± 0%      326k ± 0%  -12.64%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 745e403 into bytesparadise:master Jun 25, 2022
@xcoulon xcoulon deleted the fix_benchstat_report branch June 25, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant