Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser/renderer): trim trailing spaces in section title #1054

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 23, 2022

Fixes #1053

Signed-off-by: Xavier Coulon [email protected]

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1054 (6b667ee) into master (2375844) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   80.49%   80.57%   +0.08%     
==========================================
  Files          85       85              
  Lines        7140     7139       -1     
==========================================
+ Hits         5747     5752       +5     
+ Misses        876      870       -6     
  Partials      517      517              

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              26.2ms ± 2%    26.8ms ± 2%  +2.22%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    71.9ms ± 2%    73.6ms ± 2%  +2.30%  (p=0.004 n=10+10)
RealDocumentProcessing/mocking.adoc-2           71.7ms ± 2%    73.5ms ± 2%  +2.43%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%    10.6MB ± 0%    ~     (p=0.931 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    27.8MB ± 0%  +0.03%  (p=0.000 n=9+9)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    23.7MB ± 0%    ~     (p=0.529 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      123k ± 0%    ~     (p=0.880 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%  +0.01%  (p=0.001 n=10+9)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      350k ± 0%    ~     (p=0.868 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              26.2ms ± 2%    17.5ms ± 1%  -33.21%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    71.9ms ± 2%    50.0ms ± 1%  -30.51%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           71.7ms ± 2%    51.1ms ± 3%  -28.75%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%     8.8MB ± 0%  -16.89%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    24.0MB ± 0%  -13.71%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    21.6MB ± 0%   -8.92%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      106k ± 0%  -13.34%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.77%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      326k ± 0%   -6.71%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 53ab4a5 into bytesparadise:master Jun 23, 2022
@xcoulon xcoulon deleted the trim_section_title branch June 23, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trim trailing spaces from section title
1 participant