Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): support natural cross references #1045

Merged
merged 1 commit into from
Jun 18, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 18, 2022

reference with section title instead of ID

Fixes #1044

Signed-off-by: Xavier Coulon [email protected]

reference with section title instead of ID

Fixes bytesparadise#1044

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1045 (5be2b8a) into master (96db47f) will increase coverage by 0.21%.
The diff coverage is 81.15%.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
+ Coverage   80.31%   80.52%   +0.21%     
==========================================
  Files          85       85              
  Lines        7085     7101      +16     
==========================================
+ Hits         5690     5718      +28     
+ Misses        872      867       -5     
+ Partials      523      516       -7     

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.8ms ± 1%    25.7ms ± 1%    ~     (p=0.579 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    70.4ms ± 1%    69.8ms ± 0%  -0.77%  (p=0.006 n=10+9)
RealDocumentProcessing/mocking.adoc-2           68.9ms ± 1%    68.7ms ± 0%  -0.33%  (p=0.040 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.7MB ± 0%    10.7MB ± 0%    ~     (p=0.393 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    27.8MB ± 0%    ~     (p=0.631 n=10+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    23.7MB ± 0%    ~     (p=0.079 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      123k ± 0%    ~     (p=0.382 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%    ~     (p=0.542 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      350k ± 0%    ~     (p=0.467 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.8ms ± 1%    17.2ms ± 1%  -33.41%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    70.4ms ± 1%    48.8ms ± 2%  -30.69%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           68.9ms ± 1%    47.9ms ± 1%  -30.53%  (p=0.000 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.7MB ± 0%     8.8MB ± 0%  -17.00%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    24.0MB ± 0%  -13.79%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    21.6MB ± 0%   -8.98%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      106k ± 0%  -13.37%  (p=0.000 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.79%  (p=0.000 n=10+7)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      326k ± 0%   -6.72%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 0e73153 into bytesparadise:master Jun 18, 2022
@xcoulon xcoulon deleted the Issue1044_natural_xref branch June 18, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support natural cross references within a document
1 participant