Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): rename func to init AttributeReferences #1043

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 13, 2022

also, add test on attribute refs in links

Signed-off-by: Xavier Coulon [email protected]

also, add test on attribute refs in links

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1043 (5fb7032) into master (8adac29) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1043   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files          85       85           
  Lines        7085     7085           
=======================================
  Hits         5690     5690           
  Misses        872      872           
  Partials      523      523           

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.7ms ± 5%    25.4ms ± 1%  -1.37%  (p=0.043 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    69.3ms ± 1%    69.0ms ± 0%  -0.32%  (p=0.009 n=10+10)
RealDocumentProcessing/mocking.adoc-2           68.3ms ± 1%    68.5ms ± 1%    ~     (p=0.393 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.7MB ± 0%    10.7MB ± 0%    ~     (p=1.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    27.8MB ± 0%  +0.02%  (p=0.015 n=10+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    23.7MB ± 0%    ~     (p=0.052 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      123k ± 0%    ~     (p=0.913 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%  +0.00%  (p=0.015 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      350k ± 0%    ~     (p=0.071 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              25.7ms ± 5%    17.2ms ± 1%  -33.03%  (p=0.000 n=10+8)
RealDocumentProcessing/vertx-examples.adoc-2    69.3ms ± 1%    48.3ms ± 1%  -30.32%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           68.3ms ± 1%    47.6ms ± 1%  -30.38%  (p=0.000 n=10+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.7MB ± 0%     8.8MB ± 0%  -17.01%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.8MB ± 0%    24.0MB ± 0%  -13.78%  (p=0.000 n=10+9)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    21.6MB ± 0%   -8.99%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      106k ± 0%  -13.37%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.78%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      326k ± 0%   -6.72%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 96db47f into bytesparadise:master Jun 13, 2022
@xcoulon xcoulon deleted the rename_func branch June 13, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant