Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): detect DocumentHeader when doc has FrontMatter #1042

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 12, 2022

Only disable the 'DocumentHeader' rule if the element is not a FrontMatter (or a blankline)

Fixes #1041

Signed-off-by: Xavier Coulon [email protected]

Only disable the 'DocumentHeader' rule if the element is not a FrontMatter (or a blankline)

Fixes bytesparadise#1041

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #1042 (360905d) into master (b8e1fb4) will increase coverage by 0.07%.
The diff coverage is 97.67%.

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   80.24%   80.31%   +0.07%     
==========================================
  Files          85       85              
  Lines        7070     7085      +15     
==========================================
+ Hits         5673     5690      +17     
+ Misses        873      872       -1     
+ Partials      524      523       -1     

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              24.5ms ± 2%    24.4ms ± 2%    ~     (p=0.297 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    66.6ms ± 1%    66.7ms ± 1%    ~     (p=0.549 n=9+10)
RealDocumentProcessing/mocking.adoc-2           66.0ms ± 1%    66.9ms ± 3%  +1.39%  (p=0.001 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%    10.6MB ± 0%    ~     (p=0.730 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    27.9MB ± 0%    27.9MB ± 0%    ~     (p=0.393 n=10+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    23.7MB ± 0%  -0.01%  (p=0.023 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      123k ± 0%    ~     (p=0.650 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      350k ± 0%    ~     (p=0.270 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      350k ± 0%  -0.00%  (p=0.019 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              24.5ms ± 2%    16.2ms ± 1%  -34.09%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    66.6ms ± 1%    46.3ms ± 1%  -30.51%  (p=0.000 n=9+9)
RealDocumentProcessing/mocking.adoc-2           66.0ms ± 1%    46.4ms ± 1%  -29.59%  (p=0.000 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              10.6MB ± 0%     8.8MB ± 0%  -16.85%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2    27.9MB ± 0%    24.0MB ± 0%  -13.93%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           23.7MB ± 0%    21.6MB ± 0%   -8.89%  (p=0.000 n=10+8)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                123k ± 0%      106k ± 0%  -13.32%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2      350k ± 0%      305k ± 0%  -12.76%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             350k ± 0%      326k ± 0%   -6.69%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit 8adac29 into bytesparadise:master Jun 12, 2022
@xcoulon xcoulon deleted the Issue1041_section_rendering branch June 12, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect section rendering when doc contains frontmatter
1 participant