Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): section title parsing #1037

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented Jun 6, 2022

parse with substitutions enabled, only reparse if contains attribute refs

Signed-off-by: Xavier Coulon [email protected]

parse with substitutions enabled, only reparse if contains attribute refs

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1037 (d02ec9c) into master (8f0b39c) will decrease coverage by 0.08%.
The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   80.31%   80.22%   -0.09%     
==========================================
  Files          86       86              
  Lines        7025     7064      +39     
==========================================
+ Hits         5642     5667      +25     
- Misses        862      873      +11     
- Partials      521      524       +3     

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              24.7ms ± 3%    24.7ms ± 2%    ~     (p=0.912 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    70.1ms ± 1%    72.6ms ± 3%  +3.65%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           69.6ms ± 1%    72.7ms ± 2%  +4.38%  (p=0.000 n=9+9)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.57MB ± 0%    9.57MB ± 0%    ~     (p=0.424 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.5MB ± 0%    26.5MB ± 0%    ~     (p=0.474 n=8+10)
RealDocumentProcessing/mocking.adoc-2           22.5MB ± 0%    22.5MB ± 0%    ~     (p=0.631 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                119k ± 0%      119k ± 0%    ~     (all equal)
RealDocumentProcessing/vertx-examples.adoc-2      346k ± 0%      346k ± 0%    ~     (p=0.219 n=9+9)
RealDocumentProcessing/mocking.adoc-2             346k ± 0%      346k ± 0%    ~     (p=0.790 n=9+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              24.7ms ± 3%    17.3ms ± 1%  -29.90%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    70.1ms ± 1%    49.4ms ± 1%  -29.45%  (p=0.000 n=9+9)
RealDocumentProcessing/mocking.adoc-2           69.6ms ± 1%    49.7ms ± 5%  -28.61%  (p=0.000 n=9+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.57MB ± 0%    8.85MB ± 0%   -7.54%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.5MB ± 0%    24.0MB ± 0%   -9.39%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           22.5MB ± 0%    21.6MB ± 0%   -4.13%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                119k ± 0%      106k ± 0%  -10.58%  (p=0.000 n=6+10)
RealDocumentProcessing/vertx-examples.adoc-2      346k ± 0%      305k ± 0%  -11.78%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2             346k ± 0%      326k ± 0%   -5.61%  (p=0.000 n=9+9)

@xcoulon xcoulon merged commit c3e86f3 into bytesparadise:master Jun 6, 2022
@xcoulon xcoulon deleted the parse_section_title branch June 6, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant