Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): merge 'AdmonitionParagraph' and 'Paragraph' rules #1031

Merged

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 25, 2022

also, rename ListElementContinuation
to ListContinuation

also, rename `ListElementContinuation`
to `ListContinuation`
@github-actions
Copy link

github-actions bot commented May 25, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              17.9ms ± 1%    17.9ms ± 1%   ~     (p=0.546 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    52.8ms ± 1%    53.2ms ± 3%   ~     (p=0.905 n=9+10)
RealDocumentProcessing/mocking.adoc-2           48.4ms ± 0%    49.2ms ± 3%   ~     (p=0.105 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    9.34MB ± 0%   ~     (p=0.579 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%   ~     (p=1.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%   ~     (p=0.088 n=7+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%   ~     (all equal)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%   ~     (p=0.589 n=10+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%   ~     (p=0.103 n=10+7)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              17.9ms ± 1%    17.1ms ± 1%  -4.57%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    52.8ms ± 1%    48.2ms ± 1%  -8.83%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           48.4ms ± 0%    47.5ms ± 1%  -1.91%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.34MB ± 0%    8.85MB ± 0%  -5.20%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%  -7.91%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%  -0.56%  (p=0.000 n=7+8)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%  -6.01%  (p=0.000 n=9+10)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%  -8.18%  (p=0.000 n=10+7)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%  -0.56%  (p=0.000 n=10+10)

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1031 (04c7a1e) into master (d602a4a) will decrease coverage by 0.06%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   80.29%   80.23%   -0.07%     
==========================================
  Files          86       86              
  Lines        7013     7017       +4     
==========================================
- Hits         5631     5630       -1     
- Misses        861      866       +5     
  Partials      521      521              

@xcoulon xcoulon merged commit 113f625 into bytesparadise:master May 25, 2022
@xcoulon xcoulon deleted the refactor_documentfragment_rule_blankline branch May 25, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant