Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser/renderer): support Asciidoc content in table cells #1020

Merged
merged 1 commit into from
May 15, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 15, 2022

support other blocks such as images

Fixes #1015

Signed-off-by: Xavier Coulon [email protected]

support other blocks such as images

Fixes bytesparadise#1015

Signed-off-by: Xavier Coulon <[email protected]>
@codecov
Copy link

codecov bot commented May 15, 2022

Codecov Report

Merging #1020 (45e5c33) into master (e157d69) will decrease coverage by 0.18%.
The diff coverage is 76.34%.

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
- Coverage   80.18%   79.99%   -0.19%     
==========================================
  Files          85       85              
  Lines        6867     7078     +211     
==========================================
+ Hits         5506     5662     +156     
- Misses        857      891      +34     
- Partials      504      525      +21     

@github-actions
Copy link

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              18.5ms ± 4%    18.9ms ± 8%    ~     (p=0.190 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    55.4ms ± 2%    54.4ms ± 3%  -1.73%  (p=0.002 n=10+10)
RealDocumentProcessing/mocking.adoc-2           51.0ms ± 4%    50.0ms ± 1%  -1.95%  (p=0.043 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.35MB ± 0%    9.35MB ± 0%    ~     (p=0.393 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    26.0MB ± 0%    ~     (p=0.673 n=8+9)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.7MB ± 0%    ~     (p=0.494 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      113k ± 0%    ~     (all equal)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      332k ± 0%    ~     (p=0.231 n=6+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      328k ± 0%    ~     (p=1.000 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              18.5ms ± 4%    17.3ms ± 1%   -6.55%  (p=0.000 n=9+9)
RealDocumentProcessing/vertx-examples.adoc-2    55.4ms ± 2%    49.6ms ± 2%  -10.48%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2           51.0ms ± 4%    49.2ms ± 2%   -3.46%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.35MB ± 0%    8.85MB ± 0%   -5.39%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.0MB ± 0%    24.0MB ± 0%   -7.91%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           21.7MB ± 0%    21.6MB ± 0%   -0.52%  (p=0.000 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                113k ± 0%      106k ± 0%   -6.12%  (p=0.000 n=8+7)
RealDocumentProcessing/vertx-examples.adoc-2      332k ± 0%      305k ± 0%   -8.17%  (p=0.000 n=6+10)
RealDocumentProcessing/mocking.adoc-2             328k ± 0%      326k ± 0%   -0.53%  (p=0.000 n=10+9)

@xcoulon xcoulon merged commit 8c2d04a into bytesparadise:master May 15, 2022
@xcoulon xcoulon deleted the Issue1015_table_cell_content branch May 16, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Asciidoc content by cell in tables
1 participant