Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): simplify the 'InlineElement' rule #1007

Merged
merged 1 commit into from
May 1, 2022

Conversation

xcoulon
Copy link
Member

@xcoulon xcoulon commented May 1, 2022

Signed-off-by: Xavier Coulon [email protected]

@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1007 (ba0bf1b) into master (d590c5e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1007   +/-   ##
=======================================
  Coverage   80.15%   80.15%           
=======================================
  Files          85       85           
  Lines        6864     6864           
=======================================
  Hits         5502     5502           
  Misses        856      856           
  Partials      506      506           

@github-actions
Copy link

github-actions bot commented May 1, 2022

Comparing with master branch:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              26.1ms ± 3%    28.8ms ± 4%  +10.40%  (p=0.000 n=8+7)
RealDocumentProcessing/vertx-examples.adoc-2    81.3ms ± 3%    82.2ms ± 6%     ~     (p=0.360 n=8+10)
RealDocumentProcessing/mocking.adoc-2           75.6ms ± 2%    73.2ms ± 3%   -3.07%  (p=0.001 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.37MB ± 0%    9.37MB ± 0%     ~     (p=0.905 n=10+9)
RealDocumentProcessing/vertx-examples.adoc-2    26.6MB ± 0%    26.6MB ± 0%     ~     (p=0.068 n=9+10)
RealDocumentProcessing/mocking.adoc-2           21.8MB ± 0%    21.8MB ± 0%     ~     (p=0.243 n=10+9)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                114k ± 0%      114k ± 0%     ~     (p=1.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      343k ± 0%      343k ± 0%     ~     (p=0.488 n=10+10)
RealDocumentProcessing/mocking.adoc-2             329k ± 0%      329k ± 0%     ~     (p=0.440 n=10+10)

Comparing with latest release:

name                                          old time/op    new time/op    delta
RealDocumentProcessing/demo.adoc-2              26.1ms ± 3%    21.7ms ±10%  -16.98%  (p=0.000 n=8+9)
RealDocumentProcessing/vertx-examples.adoc-2    81.3ms ± 3%    60.2ms ± 5%  -25.93%  (p=0.000 n=8+10)
RealDocumentProcessing/mocking.adoc-2           75.6ms ± 2%    57.1ms ± 2%  -24.42%  (p=0.000 n=10+10)

name                                          old alloc/op   new alloc/op   delta
RealDocumentProcessing/demo.adoc-2              9.37MB ± 0%    8.85MB ± 0%   -5.52%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2    26.6MB ± 0%    24.0MB ± 0%   -9.86%  (p=0.000 n=9+10)
RealDocumentProcessing/mocking.adoc-2           21.8MB ± 0%    21.6MB ± 0%   -0.79%  (p=0.000 n=10+10)

name                                          old allocs/op  new allocs/op  delta
RealDocumentProcessing/demo.adoc-2                114k ± 0%      106k ± 0%   -6.36%  (p=0.000 n=10+10)
RealDocumentProcessing/vertx-examples.adoc-2      343k ± 0%      305k ± 0%  -11.04%  (p=0.000 n=10+10)
RealDocumentProcessing/mocking.adoc-2             329k ± 0%      326k ± 0%   -0.91%  (p=0.000 n=10+10)

@xcoulon xcoulon merged commit aa330c1 into master May 1, 2022
@xcoulon xcoulon deleted the simplify_inlineelement_rule branch May 1, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant