Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid section ID generation #920

Closed
xcoulon opened this issue Feb 5, 2022 · 0 comments · Fixed by #921
Closed

Invalid section ID generation #920

xcoulon opened this issue Feb 5, 2022 · 0 comments · Fixed by #921
Assignees
@xcoulon
Labels
area/parser area/renderer type/bug
Milestone
v0.7.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Feb 5, 2022

section IDs are not properly generated. In particular, special characters such as - are replaced with the idprefix value instead of being ignored: only spaces, hyphens and periods should be replaced.
See https://docs.asciidoctor.org/asciidoc/latest/sections/auto-ids/
@xcoulon xcoulon added this to the v0.7.0 milestone Feb 5, 2022
@xcoulon xcoulon self-assigned this Feb 5, 2022
@xcoulon xcoulon mentioned this issue Feb 5, 2022
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Feb 5, 2022
@xcoulon
fix(types): section id generation
e2b23a6 
support quoted strings and ignore unnecessary characters

fixes bytesparadise#920

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Feb 5, 2022
@xcoulon
fix(types): section id generation (#921)
8c0ee7a 
support quoted strings and ignore unnecessary characters

fixes #920

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser area/renderer type/bug
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

fix(types): section id generation xcoulon/libasciidoc
1 participant
@xcoulon