Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toc attribute is ignored when document header contains comments before it #916

Closed
xcoulon opened this issue Jan 30, 2022 · 0 comments · Fixed by #917
Closed

toc attribute is ignored when document header contains comments before it #916

xcoulon opened this issue Jan 30, 2022 · 0 comments · Fixed by #917
Assignees
@xcoulon
Labels
area/parser type/bug
Milestone
v0.7.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jan 30, 2022

see

= Title
// a comment
:toc: preamble

a preamble 

== Section 1

== Section 2

the // a comment line messes with the document attributes, resulting in the toc: preamble attribute being ignored 😲
@xcoulon xcoulon added this to the v0.7.0 milestone Jan 30, 2022
@xcoulon xcoulon self-assigned this Jan 30, 2022
@xcoulon xcoulon mentioned this issue Jan 30, 2022
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 30, 2022
@xcoulon
fix(parser): support comments in document header
3e05c53 
keeps the `toc` and other document attributes attached to the header,
making them available later during processing of Table of Contents, for
example.

fixes bytesparadise#916

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 30, 2022
@xcoulon
fix(parser): support comments in document header
d4853a8 
keeps the `toc` and other document attributes attached to the header,
even when there are single line comments and block comments, making them
available later during processing of Table of Contents, for example.

fixes bytesparadise#916

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Jan 30, 2022
@xcoulon
fix(parser): support comments in document header (#917)
397035b 
keeps the `toc` and other document attributes attached to the header,
even when there are single line comments and block comments, making them
available later during processing of Table of Contents, for example.

fixes #916

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

fix(parser): support comments in document header xcoulon/libasciidoc
1 participant
@xcoulon