Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore punctuation at the end of URLs #911

Closed
xcoulon opened this issue Jan 29, 2022 · 0 comments · Fixed by #914
Closed

Ignore punctuation at the end of URLs #911

xcoulon opened this issue Jan 29, 2022 · 0 comments · Fixed by #914
Assignees
@xcoulon
Labels
area/parser type/bug
Milestone
v0.7.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Jan 29, 2022

For example:

a link to https://example.com.

should render as

<div class="paragraph">
<p>a link to <a href="https://example.com" class="bare">https://example.com</a>.</p>
</div>
@xcoulon xcoulon added this to the v0.7.0 milestone Jan 29, 2022
@xcoulon xcoulon self-assigned this Jan 29, 2022
@xcoulon xcoulon mentioned this issue Jan 30, 2022
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Jan 30, 2022
@xcoulon
fix: ignore punctuation at the end of links
b960f8f 
add tests, was already fixed in bytesparadise#912

closes bytesparadise#911

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Jan 30, 2022
@xcoulon
fix: ignore punctuation at the end of links (#914)
c6590e2 
add tests, was already fixed in #912

closes #911

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

fix: ignore punctuation at the end of links xcoulon/libasciidoc
1 participant
@xcoulon