Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support attribute name in endif directive #898

Closed
xcoulon opened this issue Dec 30, 2021 · 0 comments · Fixed by #900
Closed

Support attribute name in endif directive #898

xcoulon opened this issue Dec 30, 2021 · 0 comments · Fixed by #900
Labels
area/parser type/feature
Milestone
v0.7.0

Comments

@xcoulon
Copy link
Member

xcoulon commented Dec 30, 2021

Eg:

ifdef::an_attribute[]
conditional content here
endif::an_attribute[]
@xcoulon xcoulon added this to the v0.7.0 milestone Dec 30, 2021
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Dec 31, 2021
@xcoulon
feat(parser): support attribute name in 'endif' directive
8920b23 
name is parsed but no check is done with regards to current ifdef/ifnded
directives.

fixes bytesparadise#898

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Dec 31, 2021
Merged
xcoulon added a commit that referenced this issue Dec 31, 2021
@xcoulon
feat(parser): support attribute name in 'endif' directive (#900)
d26aa45 
name is parsed but no check is done with regards to current ifdef/ifnded
directive.

fixes #898

Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser type/feature
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

feat(parser): support attribute name in 'endif' directive xcoulon/libasciidoc
1 participant
@xcoulon