Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misparsed line breaks in macro attribute lists #850

Closed
pjanx opened this issue Jul 23, 2021 · 6 comments · Fixed by #858
Closed

Misparsed line breaks in macro attribute lists #850

pjanx opened this issue Jul 23, 2021 · 6 comments · Fixed by #858
Assignees
Milestone

Comments

@pjanx
Copy link
Contributor

pjanx commented Jul 23, 2021

link:x[
title]

on master produces:

<div class="paragraph">
<p>link:x[
title]</p>
</div>

but should give (Asciidoctor):

<div class="paragraph">
<p><a href="x">
title</a></p>
</div>

More of a long-time annoyance, though it'd be good to think of this during the refactoring.

@xcoulon
Copy link
Member

xcoulon commented Jul 25, 2021

thanks for reporting this issue @pjanx, I will take a look at it once I'm done with #843

@xcoulon xcoulon self-assigned this Jul 25, 2021
@xcoulon xcoulon added this to the v0.7.0 milestone Jul 25, 2021
@xcoulon
Copy link
Member

xcoulon commented Nov 19, 2021

<div class="paragraph">
<p><a href="x">
title</a></p>
</div>

out of curiosity, is preserving the line break between <a href="x"> and title something significant for you? It doesn't seem to be rendered explicitly by the browser, so I would prefer producing the following output instead:

<div class="paragraph">
<p><a href="x">title</a></p>
</div>

@pjanx
Copy link
Contributor Author

pjanx commented Nov 19, 2021

It's all about word wrapping.

To me, this looks like normal inline content, syntactically. I wouldn't expect a line break to carry over.

@xcoulon
Copy link
Member

xcoulon commented Nov 19, 2021

ok, thanks for your feedback!

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Nov 20, 2021
xcoulon added a commit that referenced this issue Nov 20, 2021
@pjanx
Copy link
Contributor Author

pjanx commented Nov 20, 2021

Christmas is early this year.

@xcoulon
Copy link
Member

xcoulon commented Nov 20, 2021

Christmas is early this year.

😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants