feat(parser): support custom substitutions on delimited blocks #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
- Coverage 83.52% 81.25% -2.28%
==========================================
Files 77 76 -1
Lines 5603 5014 -589
==========================================
- Hits 4680 4074 -606
- Misses 586 606 +20
+ Partials 337 334 -3 |
xcoulon
force-pushed
the
Issue558_custom_block_substitutions
branch
2 times, most recently
from
aa11dcf to
6c42006
Compare
xcoulon
force-pushed
the
Issue558_custom_block_substitutions
branch
from
6c42006 to
adc13f4
Compare
applying the same logic as with paragraphs to apply default and custom substitutions on delimited blocks. This means that delimited blocks are processed in multiple steps, but each step has a much simpler grammar. Also, quite a lot of refactoring and code reorganization for the delimited block tests in `pkg/parser`. See bytesparadise#749 Fixes bytesparadise#558 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
force-pushed
the
Issue558_custom_block_substitutions
branch
from
adc13f4 to
3cf0426
Compare
|
finally! 😅 |
xcoulon
added a commit
to xcoulon/libasciidoc
that referenced
this pull request
Sep 28, 2020
issue was fixed by bytesparadise#755, verifying it here Fixes bytesparadise#748 Signed-off-by: Xavier Coulon <[email protected]>
xcoulon
added a commit
that referenced
this pull request
Sep 28, 2020
issue was fixed by #755, verifying it here Fixes #748 Signed-off-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applying the same logic as with paragraphs to apply default and
custom substitutions on delimited blocks. This means that
delimited blocks are processed in multiple steps, but each step
has a much simpler grammar.
Also, quite a lot of refactoring and code reorganization for the
delimited block tests in
pkg/parser.See #749
Fixes #558
Signed-off-by: Xavier Coulon [email protected]