Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document details not parsed if document has leading newlines #707

Closed
gdamore opened this issue Jul 9, 2020 · 4 comments · Fixed by #757
Closed

Document details not parsed if document has leading newlines #707

gdamore opened this issue Jul 9, 2020 · 4 comments · Fixed by #757
Labels
area/parser type/bug
Milestone
v0.5.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jul 9, 2020

If a document has leading whitespace, like this:


= My title
Garrett D'Amore
1.0, July 4, 2020

The document details don't seem to be recognized. libasciidoctor is fine with it.
@xcoulon
Copy link
Member

xcoulon commented Jul 9, 2020

what do you mean by "libasciidoctor is fine with it."?

@xcoulon xcoulon added this to the v0.5.0 milestone Jul 9, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jul 10, 2020

asciidoctor I meant. Sorry. Was late at night.

@xcoulon
Copy link
Member

xcoulon commented Jul 10, 2020

asciidoctor I meant. Sorry. Was late at night.

no problem ;) It's what I thought too (that you meant Asciidoctor)

xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 28, 2020
@xcoulon
test(parser): verify document with leading empty line
8bc27f1 
verify that document metadata are recognized when the
content starts with an empty line

Fixes bytesparadise#707

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Sep 28, 2020
Merged
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 28, 2020
@xcoulon
test(parser): verify document with leading empty line
862977d 
verify that document metadata are recognized when the
content starts with an empty line

Fixes bytesparadise#707

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Sep 29, 2020
@xcoulon
fix(parser): verify document with leading empty line
f31c7a0 
ignore heading blank lines after the front-matter

Fixes bytesparadise#707

Signed-off-by: Xavier Coulon <[email protected]>
xcoulon added a commit that referenced this issue Sep 29, 2020
@xcoulon
fix(parser): verify document with leading empty line (#757)
921565a 
ignore heading blank lines after the front-matter

Fixes #707

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Sep 29, 2020

@gdamore sorry for the late response, I was caught with #597 and #558 🤯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/parser type/bug
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

test(parser): verify document with leading empty line xcoulon/libasciidoc
2 participants
@xcoulon @gdamore