features(types/renderer): Table cols attribute support #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdamore
added a commit
to gdamore/libasciidoc
that referenced
this pull request
Jul 5, 2020
…#698) This adds support for handling the cols attribute ont tables, giving the ability specify per column widths and alignments. It also supports the repeat syntax, and the ability to set autoexpand (either for the entire table or for an individual row). The width handling and calculations were moved to instantiation time for the Table, so that all backends can benefit from the calculation work done for these. The style component of the column specification is consumed and stored, but does not affect deeper parsing or rendering yet. This takes table support about as far as it can go without reworking the parser to provide context-sensitive parsing of the table contents. While here the limitations document was updated to provide more detail on limitations, including links to issues for folks who want to track progress. Fixes bytesparadise#694 Fixes bytesparadise#686
|
Full rebased now. I believe this PR substantially increases the number of tables in the wild that will be handled correctly. |
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
=======================================
Coverage 84.43% 84.44%
=======================================
Files 74 75 +1
Lines 5024 5123 +99
=======================================
+ Hits 4242 4326 +84
- Misses 501 512 +11
- Partials 281 285 +4 |
…#698) This adds support for handling the cols attribute ont tables, giving the ability specify per column widths and alignments. It also supports the repeat syntax, and the ability to set autoexpand (either for the entire table or for an individual row). The width handling and calculations were moved to instantiation time for the Table, so that all backends can benefit from the calculation work done for these. The style component of the column specification is consumed and stored, but does not affect deeper parsing or rendering yet. This takes table support about as far as it can go without reworking the parser to provide context-sensitive parsing of the table contents. While here the limitations document was updated to provide more detail on limitations, including links to issues for folks who want to track progress. Fixes bytesparadise#694 Fixes bytesparadise#686
|
also, thanks for the big update in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for handling the cols attribute ont tables,
giving the ability specify per column widths and alignments.
It also supports the repeat syntax, and the ability to set
autoexpand (either for the entire table or for an individual row).
The width handling and calculations were moved to instantiation
time for the Table, so that all backends can benefit from the
calculation work done for these.
The style component of the column specification is consumed and
stored, but does not affect deeper parsing or rendering yet.
This takes table support about as far as it can go without
reworking the parser to provide context-sensitive parsing of
the table contents.
While here the limitations document was updated to provide more
detail on limitations, including links to issues for folks
who want to track progress.
Fixes #694
Fixes #686