Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limitations list doesn't reflect the state of affairs with quoted text handling #686

Closed
gmarpons opened this issue Jul 4, 2020 · 1 comment · Fixed by #698
Closed

Limitations list doesn't reflect the state of affairs with quoted text handling #686

gmarpons opened this issue Jul 4, 2020 · 1 comment · Fixed by #698
Assignees
@gdamore
Labels
area/docs type/chore
Milestone
v0.5.0

Comments

@gmarpons
Copy link

gmarpons commented Jul 4, 2020

I've just tested the tool and https://github.com/bytesparadise/libasciidoc/blob/master/LIMITATIONS.adoc#quoted-text seems out of date to me: both examples in that section work exactly as in Asciidoctor.

By the way, very good tool, congrats!
@xcoulon
Copy link
Member

xcoulon commented Jul 4, 2020

oh, looks like we need to update the doc here :)
thanks a lot for the feedback!

@xcoulon xcoulon added this to the v0.5.0 milestone Jul 4, 2020
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jul 5, 2020
@gdamore
features(types/renderer): Table cols attribute support
5a4178f 
This adds support for handling the cols attribute ont tables,
giving the ability specify per column widths and alignments.
It also supports the repeat syntax, and the ability to set
autoexpand (either for the entire table or for an individual row).

The width handling and calculations were moved to instantiation
time for the Table, so that all backends can benefit from the
calculation work done for these.

The style component of the column specification is consumed and
stored, but does not affect deeper parsing or rendering yet.

This takes table support about as far as it can go without
reworking the parser to provide context-sensitive parsing of
the table contents.

While here the limitations document was updated to provide more
detail on limitations, including links to issues for folks
who want to track progress.

Fixes bytesparadise#694
Fixes bytesparadise#686
@gdamore gdamore mentioned this issue Jul 5, 2020
Merged
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jul 5, 2020
@gdamore
features(types/renderer): Table cols attribute support (bytesparadise…
5af260e 
…#698)

This adds support for handling the cols attribute ont tables,
giving the ability specify per column widths and alignments.
It also supports the repeat syntax, and the ability to set
autoexpand (either for the entire table or for an individual row).

The width handling and calculations were moved to instantiation
time for the Table, so that all backends can benefit from the
calculation work done for these.

The style component of the column specification is consumed and
stored, but does not affect deeper parsing or rendering yet.

This takes table support about as far as it can go without
reworking the parser to provide context-sensitive parsing of
the table contents.

While here the limitations document was updated to provide more
detail on limitations, including links to issues for folks
who want to track progress.

Fixes bytesparadise#694
Fixes bytesparadise#686
@gdamore gdamore self-assigned this Jul 5, 2020
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jul 5, 2020
@gdamore
features(types/renderer): Table cols attribute support (bytesparadise…
cb614f0 
…#698)

This adds support for handling the cols attribute ont tables,
giving the ability specify per column widths and alignments.
It also supports the repeat syntax, and the ability to set
autoexpand (either for the entire table or for an individual row).

The width handling and calculations were moved to instantiation
time for the Table, so that all backends can benefit from the
calculation work done for these.

The style component of the column specification is consumed and
stored, but does not affect deeper parsing or rendering yet.

This takes table support about as far as it can go without
reworking the parser to provide context-sensitive parsing of
the table contents.

While here the limitations document was updated to provide more
detail on limitations, including links to issues for folks
who want to track progress.

Fixes bytesparadise#694
Fixes bytesparadise#686
xcoulon pushed a commit that referenced this issue Jul 6, 2020
@gdamore
features(types/renderer): Table cols attribute support (#698) (#698)
122f8da 
This adds support for handling the cols attribute ont tables,
giving the ability specify per column widths and alignments.
It also supports the repeat syntax, and the ability to set
autoexpand (either for the entire table or for an individual row).

The width handling and calculations were moved to instantiation
time for the Table, so that all backends can benefit from the
calculation work done for these.

The style component of the column specification is consumed and
stored, but does not affect deeper parsing or rendering yet.

This takes table support about as far as it can go without
reworking the parser to provide context-sensitive parsing of
the table contents.

While here the limitations document was updated to provide more
detail on limitations, including links to issues for folks
who want to track progress.

Fixes #694
Fixes #686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
area/docs type/chore
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

features(types/renderer): Table cols attribute support gdamore/libasciidoc
3 participants
@xcoulon @gmarpons @gdamore