feature(parser/renderer): unordered lists should support style #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts unordered lists so that they can support multiple roles, and the style attribute properly. It includes both the parser side and renderer side changes. The templates were converted to use the exact HTML output that asciidoctor emits. Fixes bytesparadise#658
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
+ Coverage 85.97% 85.99% +0.01%
==========================================
Files 70 71 +1
Lines 4705 4711 +6
==========================================
+ Hits 4045 4051 +6
Misses 408 408
Partials 252 252 |
xcoulon
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts unordered lists so that they can support multiple
roles, and the style attribute properly. It includes both the
parser side and renderer side changes. The templates were
converted to use the exact HTML output that asciidoctor emits.
Fixes #658