Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unordered lists should support style #658

Closed
gdamore opened this issue Jun 28, 2020 · 5 comments · Fixed by #660
Closed

unordered lists should support style #658

gdamore opened this issue Jun 28, 2020 · 5 comments · Fixed by #660
Assignees
@gdamore
Labels
area/parser area/renderer type/feature
Milestone
v0.5.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jun 28, 2020 •
edited
Loading

Unordered list are supposed to support the following styles

  • square
  • circle
  • disc
  • none or no-bullet (indented, but no bullet)
  • unstyled (no indentation or bullet) (HTML only)

According to the docs for asciidoctor, these are placed as the class on the <ul> element.
@gdamore gdamore self-assigned this Jun 28, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jun 28, 2020

I'm fixing this as part of the work to generalize the parser for multiple roles.

@gdamore gdamore added this to the v0.5.0 milestone Jun 28, 2020
@xcoulon
Copy link
Member

xcoulon commented Jun 28, 2020

I'm fixing this as part of the work to generalize the parser for multiple roles.

wouldn't it be better to address this in a separate PR? It's not directly related to multiple roles on elements, is it?

@gdamore
Copy link
Collaborator Author

gdamore commented Jun 28, 2020

This will be a PR that introduces two components -- the first is the parser support (which is basically just making it use BlockAttr), and the second is the changes to the templates to actually use the style Attribute.

@gdamore
Copy link
Collaborator Author

gdamore commented Jun 28, 2020

Also, doing two separate PRs substantially increases the workload. The PR review itself is bigger, but more to the point I have to write the tests once, and then rewrite (and add more) them for the follow up. I'd just assume skip some of the middle bits.

@gdamore
Copy link
Collaborator Author

gdamore commented Jun 28, 2020

(This will be a PR with only the unordered list conversion though.)

gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 28, 2020
@gdamore
feature(parser/renderer): unordered lists should support style
7074a90 
This converts unordered lists so that they can support multiple
roles, and the style attribute properly.  It includes both the
parser side and renderer side changes.  The templates were
converted to use the exact HTML output that asciidoctor emits.

Fixes bytesparadise#658
@gdamore gdamore mentioned this issue Jun 28, 2020
Merged
xcoulon pushed a commit that referenced this issue Jun 28, 2020
@gdamore
feature(parser/renderer): unordered lists should support style (#660)
c93bc82 
This converts unordered lists so that they can support multiple
roles, and the style attribute properly.  It includes both the
parser side and renderer side changes.  The templates were
converted to use the exact HTML output that asciidoctor emits.

Fixes #658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
area/parser area/renderer type/feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

feature(parser/renderer): unordered lists should support style gdamore/libasciidoc
2 participants
@xcoulon @gdamore