feature(renderer): htmlEscape should escape quotes #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes all single and double quotes escaped in SGML content, improving the safety of using these characters inline.
|
This forced a lot of tests to be updated. |
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 70 70
Lines 4685 4685
=======================================
Hits 4035 4035
Misses 400 400
Partials 250 250 |
|
great, thanks for taking care of this @gdamore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all single and double quotes escaped in SGML content,
improving the safety of using these characters inline.
Fixes #644