Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

htmlEscaper should escape quotes #644

Closed
gdamore opened this issue Jun 25, 2020 · 1 comment · Fixed by #647
Closed

htmlEscaper should escape quotes #644

gdamore opened this issue Jun 25, 2020 · 1 comment · Fixed by #647
Assignees
@gdamore
Labels
area/renderer type/feature
Milestone
v0.5.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jun 25, 2020

Both ' and "" should be escaped for safety (after other replacements) as fields here may be placed into HTML attributes by templates.

For HTML (and SGML etc.) it is always safe to replace these with entities, provided they are part of user content (i.e. not explicitly part of the HTML markup itself.)
@xcoulon xcoulon added this to the v0.5.0 milestone Jun 25, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jun 25, 2020

I'll take this. I've already looked at it a bit.

@gdamore gdamore self-assigned this Jun 25, 2020
@gdamore gdamore mentioned this issue Jun 25, 2020
Merged
@gdamore gdamore mentioned this issue Jun 26, 2020
Merged
xcoulon pushed a commit that referenced this issue Jun 26, 2020
@gdamore
feature(renderer): htmlEscape should escape quotes (#647)
991725d 
This makes all single and double quotes escaped in SGML content,
improving the safety of using these characters inline.

Fixes #644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
area/renderer type/feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

feature(renderer): htmlEscape should escape quotes gdamore/libasciidoc
2 participants
@xcoulon @gdamore