Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support thematic break element #617

Closed
gdamore opened this issue Jun 16, 2020 · 1 comment
Closed

Support thematic break element #617

gdamore opened this issue Jun 16, 2020 · 1 comment
Assignees
@gdamore
Labels
area/parser area/renderer type/feature
Milestone
v0.5.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jun 16, 2020 •
edited by xcoulon
Loading

The thematic break element (***) in asciidoc is meant to render to an <hr> (or <hr/>)

Note that asciidoctor currently permits no styling of this element (which is probably somewhat unfortunate -- as it could be useful to style different rulers differently based on where they appear in a document.)
@xcoulon xcoulon added this to the backlog milestone Jun 23, 2020
@gdamore gdamore self-assigned this Jun 24, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jun 24, 2020

This change is almost trivial. I've got a PR incoming.

@gdamore gdamore modified the milestones: backlog, v0.5.0 Jun 24, 2020
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 24, 2020
@gdamore
feat(parser/renderer) Support for thematic breaks
8c3dd32 
This adds support for all six forms of thematic break supported
by asciidoctor.

Fixes bytesparadise#617
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 24, 2020
@gdamore
feat(parser/renderer) Support for thematic breaks
a251ed0 
This adds support for all six forms of thematic break supported
by asciidoctor.

Fixes bytesparadise#617
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 24, 2020
@gdamore
feat(parser/renderer) Support for thematic breaks
120709c 
This adds support for all six forms of thematic break supported
by asciidoctor.

Fixes bytesparadise#617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
area/parser area/renderer type/feature
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
2 participants
@xcoulon @gdamore