Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colons, images and icons not supported in definition list terms #614

Closed
gdamore opened this issue Jun 16, 2020 · 1 comment
Closed

colons, images and icons not supported in definition list terms #614

gdamore opened this issue Jun 16, 2020 · 1 comment
Assignees
@gdamore
Labels
area/parser type/bug
Milestone
v0.5.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jun 16, 2020

The existing grammar for definition lists (labeled lists) imposes some limits on the labels. In particular, it precludes the use of a colon, which means we cannot use inline icons or images.

There may be other limitations if other inline elements need the colon. It also precludes the use of a colon in user text.
@gdamore gdamore self-assigned this Jun 16, 2020
@gdamore gdamore added this to the v0.5.0 milestone Jun 16, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jun 16, 2020

Turns out this is a pretty easy thing to fix.

gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 16, 2020
@gdamore
bug(parser): colons, images and icons not supported in list terms
5b60e00 
Fixes bytesparadise#614
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 16, 2020
@gdamore
fix(parser): colons, images and icons not supported in list terms
0bd84a9 
Fixes bytesparadise#614
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 16, 2020
@gdamore
fix(parser): colons, images and icons not supported in list terms
969c076 
Fixes bytesparadise#614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@gdamore