icon attribute support #611
Comments
gdamore
added a commit
to gdamore/libasciidoc
that referenced
this issue
Jun 15, 2020
feat(renderer/types): icon attribute support feat(renderer): Support image based icons This adds inline icon support, and significantly refactors the icon handling to bring in support for image based icons and all of the icon attributes supported by asciidoctor, bringing us to feature parity. Additionally, we preserve some of the attributes from the font icon tags onto images, allowing flip, rotate, and size styles to be applied to icons. (This is an improvement over asciidoctor, and requires supporting CSS.) One subtle difference when comparing output. We emit source paths for images without a leading "./". That is because our use of path.Join() automatically removes the redundant portion. fixes bytesparadise#587 fixes bytesparadise#611 fixes bytesparadise#610
gdamore
added a commit
to gdamore/libasciidoc
that referenced
this issue
Jun 15, 2020
This adds inline icon support, and significantly refactors the icon handling to bring in support for image based icons and all of the icon attributes supported by asciidoctor, bringing us to feature parity. Additionally, we preserve some of the attributes from the font icon tags onto images, allowing flip, rotate, and size styles to be applied to icons. (This is an improvement over asciidoctor, and requires supporting CSS.) One subtle difference when comparing output. We emit source paths for images without a leading "./". That is because our use of path.Join() automatically removes the redundant portion. Fixes bytesparadise#587 Fixes bytesparadise#611 Fixes bytesparadise#610
xcoulon
added a commit
that referenced
this issue
Jun 16, 2020
This adds inline icon support, and significantly refactors the icon handling to bring in support for image based icons and all of the icon attributes supported by Asciidoctor, bringing us to feature parity. Additionally, we preserve some of the attributes from the font icon tags onto images, allowing flip, rotate, and size styles to be applied to icons. (This is an improvement over Asciidoctor, and requires supporting CSS.) One subtle difference when comparing output. We emit source paths for images without a leading "./". That is because our use of `path.Join()` automatically removes the redundant portion. Fixes #587 Fixes #611 Fixes #610 Co-authored-by: Xavier Coulon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There a bunch of attributes for icons that should be supported. Size, rotation, flip, etc. Also for image icons there are more like width, height.
We also want to support making these clickable links with the link attribute.
I'm addressing these all with the work to support inline icons.
The text was updated successfully, but these errors were encountered: