Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wanted for #mark# syntax #599

Closed
gdamore opened this issue Jun 13, 2020 · 2 comments · Fixed by #600
Closed

Support wanted for #mark# syntax #599

gdamore opened this issue Jun 13, 2020 · 2 comments · Fixed by #600
Assignees
@gdamore
Labels
area/parser area/renderer type/feature
Milestone
v0.5.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Jun 13, 2020 •
edited by xcoulon
Loading

The #mark# syntax adds markup in one of two ways.

With the default role, it looks like highlighted text. (It uses <mark>.)

With a role, it uses a <span> element with the class matching the mark. This allows documents to apply an arbitrary style to a range of text, which they can then control via CSS.

The solution to this should build upon the work done by #588.
@gdamore gdamore self-assigned this Jun 13, 2020
@gdamore gdamore added this to the v0.5.0 milestone Jun 13, 2020
@gdamore
Copy link
Collaborator Author

gdamore commented Jun 13, 2020 •
edited by xcoulon
Loading

I added this to v0.5 for now. Hope that's ok. Once #588 is merged, adding this will be relatively straight-forward.

@xcoulon
Copy link
Member

xcoulon commented Jun 13, 2020

ok, sounds good to me!

gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 14, 2020
@gdamore
feat(parser/renderer): Support wanted for #mark# syntax
eb71542 
Fixes bytesparadise#599.

This adds support for the #mark# style, including support for
using the role attribute to change <mark> into <span>.
@gdamore gdamore mentioned this issue Jun 14, 2020
Merged
gdamore added a commit to gdamore/libasciidoc that referenced this issue Jun 14, 2020
@gdamore
feat(parser/renderer): Support wanted for #mark# syntax
eaf04dc 
Fixes bytesparadise#599.

This adds support for the #mark# style, including support for
using the role attribute to change <mark> into <span>.
xcoulon pushed a commit that referenced this issue Jun 14, 2020
@gdamore
feat(parser/renderer): Support wanted for #mark# syntax (#600)
90b4f2d 
This adds support for the `#mark#` style, including support for
using the role attribute to change `<mark>` into `<span>`.

Fixes #599.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdamore gdamore

Labels
area/parser area/renderer type/feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

599 Support for #mark gdamore/libasciidoc
2 participants
@xcoulon @gdamore