Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser error from Concealed Index term #502

Closed
gdamore opened this issue Mar 15, 2020 · 5 comments · Fixed by #507
Closed

parser error from Concealed Index term #502

gdamore opened this issue Mar 15, 2020 · 5 comments · Fixed by #507
Assignees
@xcoulon
Labels
area/parser type/bug
Milestone
v0.4.0

Comments

@gdamore
Copy link
Collaborator

gdamore commented Mar 15, 2020 

PS C:\Users\garre\Work\nng\docs\man> libasciidoc.exe .\nng_sub.7.adoc
Error: unable to render full document: failed to render document elements: error while rendering section: template: section 1:3:41: executing "section 1" at <renderElements $ctx .Elements>: error calling renderElements: error while rendering section: template: other section:2:35: executing "other section" at <renderElements $ctx .Elements>: error calling renderElements: unable to render labeled list: template: labeled list with default layout:4:84: executing "labeled list with default layout" at <renderInlineElements $ctx $item.Term>: error calling renderInlineElements: unable to render line: unsupported type of element: types.ConcealedIndexTerm
Usage:
  libasciidoc [flags] FILE
  libasciidoc [command]

The source document is here:

https://github.com/nanomsg/nng/blob/master/docs/man/nng_sub.7.adoc
@gdamore
Copy link
Collaborator Author

gdamore commented Mar 15, 2020

There are a lot of docs in that directory, and they all parse properly with asciidoctor.

I'm trying to automate this with libasciidoc, but ... until I can convert them all, I can't make the switch.

@gdamore
Copy link
Collaborator Author

gdamore commented Mar 15, 2020

Btw, thanks so much for work on this to this point -- I have high hopes for this project!

@xcoulon
Copy link
Member

xcoulon commented Mar 15, 2020

@gdamore ok, thanks for reporting this issue and sorry that you have to face so many bugs 😬
I will take a look at it.

@xcoulon xcoulon self-assigned this Mar 15, 2020
@xcoulon xcoulon added this to the v0.4.0 milestone Mar 15, 2020
xcoulon added a commit to xcoulon/libasciidoc that referenced this issue Mar 17, 2020
@xcoulon
fix(parser/renderer): support concelead index terms in labeled lists
321dbc5 
do not exclude ConceledIndexTerms (and Blanklines)
in final document, but silently ignore them in the  HTML rendering phase.

also, do not print help when an error occurs when running from CLI

Fixes bytesparadise#502

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon xcoulon mentioned this issue Mar 17, 2020
Merged
xcoulon added a commit that referenced this issue Mar 17, 2020
@xcoulon
fix(parser/renderer): support concelead index terms in labeled lists (#…
1b574d6 
…507)

do not exclude ConceledIndexTerms (and Blanklines)
in final document, but silently ignore them in the  HTML rendering phase.

also, do not print help when an error occurs when running from CLI

Fixes #502

Signed-off-by: Xavier Coulon <[email protected]>
@xcoulon
Copy link
Member

xcoulon commented Mar 17, 2020

@gdamore this should be fixed now. Could you give it a try, please?

@xcoulon
Copy link
Member

xcoulon commented Mar 17, 2020

@gdamore I will also work on supporting the -R and -D arguments as in Asciidoctor, so you can process a whole directory in a single command. See #508

@xcoulon xcoulon modified the milestones: v0.4.0, v0.3.1 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcoulon xcoulon

Labels
area/parser type/bug
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

fix(parser/renderer): support concelead index terms in labeled lists xcoulon/libasciidoc
2 participants
@xcoulon @gdamore